From 7432b6ce9157b18aaeb9d5b03b34d8dfd747eb9a Mon Sep 17 00:00:00 2001 From: Shawn Hoffman Date: Mon, 12 Sep 2022 03:35:03 -0700 Subject: [PATCH] Updater: Move inflate intermediate buffer to heap and enlarge --- Source/Core/UpdaterCommon/UpdaterCommon.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Source/Core/UpdaterCommon/UpdaterCommon.cpp b/Source/Core/UpdaterCommon/UpdaterCommon.cpp index 6bbe5b936a..fb9606ca49 100644 --- a/Source/Core/UpdaterCommon/UpdaterCommon.cpp +++ b/Source/Core/UpdaterCommon/UpdaterCommon.cpp @@ -4,6 +4,7 @@ #include "UpdaterCommon/UpdaterCommon.h" #include +#include #include #include @@ -132,16 +133,17 @@ std::optional GzipInflate(const std::string& data) inflateInit2(&zstrm, 16 + MAX_WBITS); std::string out; - char buffer[4096]; + const size_t buf_len = 20 * 1024 * 1024; + auto buffer = std::make_unique(buf_len); int ret; do { - zstrm.avail_out = sizeof(buffer); - zstrm.next_out = reinterpret_cast(buffer); + zstrm.avail_out = buf_len; + zstrm.next_out = reinterpret_cast(buffer.get()); ret = inflate(&zstrm, 0); - out.append(buffer, sizeof(buffer) - zstrm.avail_out); + out.append(buffer.get(), buf_len - zstrm.avail_out); } while (ret == Z_OK); inflateEnd(&zstrm);