mirrors/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-10 13:21:39 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
24,195 Commits 6 Branches 12 Tags 1.4 GiB
643b218c1d
Commit Graph

781 Commits

Author SHA1 Message Date
Léo Lam
ac27aff9c8 Add ES::Content::IsShared to avoid hardcoding 0x8000 2017-03-01 17:36:07 +01:00
Léo Lam
6327a29847 IOS/ES: Implement ES_Export* ioctlvs 
This should allow channels to be copied to the SD properly.
 2017-02-27 21:26:28 +01:00
Léo Lam
44a3db21e4 ES: Make sure the TMD and ticket are valid before use 2017-02-26 19:46:30 +01:00
Léo Lam
5104caf6a6 Move AES code to Common/Crypto 2017-02-26 19:46:30 +01:00
Léo Lam
c1a139e8ac Use ESFormats for TMDs 
We already have a TMDReader, so let's actually use it.

And move ESFormats to IOS::ES, since it's definitely part of IOS.
This adds a DiscIO dependency on Core which will be fixed in a
follow-up PR.
 2017-02-26 19:46:29 +01:00
Léo Lam
bf1f70db0a Move the ticket code to ESFormats 
This moves some parsing code for tickets and ticket views to ESFormats
instead of duplicating it over DiscIO and Core.
 2017-02-26 19:46:28 +01:00
JosJuice
298e81881f Forward declare IBlobReader in Volume headers 
We have to do this (or include Blob.h) since the
constructors take unique_ptr<IBlobReader> parameters.
 2017-02-19 08:40:30 +01:00
JosJuice
f80f7b6f9c Merge pull request #4883 from JosJuice/dvd-timing-address-translation-2 
DVDInterface: Translate Wii partition offsets for timing purposes
 2017-02-15 21:12:42 +01:00
JosJuice
49ec22bc42 DVDInterface: Translate Wii partition offsets for timing purposes 
Until now, Dolphin has been using the wrong values
for calculating DVD timing for decrypted Wii reads
(which Wii games essentially always use).
 2017-02-12 09:37:39 +01:00
JosJuice
c96bcace2f VolumeWiiCrypted: Use constant naming style for constants 2017-02-11 12:56:48 +01:00
Léo Lam
850802ea88 Get rid of a singleton for NAND shared contents 
This also allows shared contents to be installed to the configured root
when installing a WAD.
 2017-02-10 22:46:38 +01:00
Léo Lam
7a1f676ef4 Always use configured root when installing WAD 
This prevents Dolphin from writing to /sys/uid.sys (on the host; root
partition) when installing a WAD before starting emulation, because
the session root is not initialized at that moment.

Incidentally, this also gets rid of a singleton.
 2017-02-10 19:12:08 +01:00
Lioncash
e07383a783 Core: Convert State enum into an enum class 2017-02-05 08:32:23 -05:00
Matthew Parlane
017e8050b6 Merge pull request #4746 from JosJuice/volumedirectory-sort-case-insensitive 
VolumeDirectory: Use case-insensitive comparison when sorting
 2017-01-27 18:23:14 +13:00
JosJuice
104faa9fb3 VolumeDirectory: Use case-insensitive comparison when sorting 
This fixes a regression from 5.0-1556, but I don't know why
the regression occurred or why this fixes it. (Many games
failed to fully boot - I tried Metroid Prime and Twilight
Princess (both GC), and they never got to the title screen.)
 2017-01-25 15:07:07 +01:00
Léo Lam
3d21280ab4 DiscIO: Fix out-of-bounds access in NANDContentDataBuffer 
Accessing buffer[start + size] triggers an error (and a crash) in debug
builds. Using std::copy_n fixes this.
 2017-01-23 21:49:26 +01:00
Léo Lam
b892d78872 VolumeWad: Implement GetTMD() 
This allows getting useful info like the required IOS version for WADs
(for showing it in the UI, for example).
 2017-01-23 20:59:02 +01:00
Léo Lam
f89aaee91a VolumeWad: Remove useless else after return 2017-01-23 18:17:34 +01:00
Léo Lam
2cd287baf7 VolumeWad: Add missing forward declaration 2017-01-23 18:17:34 +01:00
Léo Lam
6128679396 VolumeWad: Clean up variable naming 2017-01-23 18:07:23 +01:00
Léo Lam
6d909b3e30 VolumeWad: In-class initialise member variables 2017-01-23 18:07:21 +01:00
Markus Wick
90ee85f4e8 Merge pull request #4714 from JosJuice/wbfs-file-entry 
Fix -Wshadow warning for file_entry
 2017-01-22 17:56:51 +01:00
JosJuice
79f3b5c5ff Fix -Wshadow warning for file_entry 
This struct didn't follow our naming convention,
so let's rename the struct itself instead of
the variable that triggered the warning.
 2017-01-22 17:27:37 +01:00
BhaaL
07d1f18f53 CompressFileToBlob: add an explicit seek to make sure we're at the start 2017-01-21 21:42:58 +01:00
BhaaL
30e0f3d9ca DecompressFileToBlob: don't assume success if decompression failed 2017-01-21 21:42:58 +01:00
BhaaL
24be8c0814 IsGCZBlob: try to leave the file position where it was before 
callers that don't seek afterwards might be missing a few bytes that way.
 2017-01-21 21:42:57 +01:00
Pierre Bourdon
334ddf754e DiscIO: Export GetKeyFromTicket 
This function has more uses than just in DiscIO (e.g. WFS).
 2017-01-14 17:06:40 +01:00
Pierre Bourdon
650a1fdb1f DiscIO: Implement functions to lookup tickets 
These two functions load either a signed ticket or a raw ticket from the
emulated NAND.

The ticket signature skip is refactored out of the ticket writing in
order to be usable by the raw ticket reading function.
 2017-01-14 17:06:40 +01:00
Pierre Bourdon
2ed352698f IOS/ES: Implement ES_AddTicket. 
Refactor the existing DiscIO::AddTicket to not require the caller to
pass the requested title ID. We do not have the title ID in the ES case,
and it needs to be extracted from the ticket. Since this is always a
safe operation to do (title ID is always in the ticket), the
implementation is made default.
 2017-01-14 15:23:16 +01:00
Matthew Parlane
9838afea41 Merge pull request #4479 from GerbilSoft/feature/RVT-R.dev-key 
Support for RVT-R disc images
 2017-01-13 09:56:50 +13:00
Matthew Parlane
d346d4ced1 Merge pull request #4544 from JosJuice/region-enum 
DiscIO: Add GetRegion function and Region enum
 2017-01-13 09:19:27 +13:00
JosJuice
b1873264d7 WbfsBlob: Don't wrap file_entry in std::unique_ptr 
There doesn't seem to be any reason for doing it.
 2017-01-11 13:39:46 +01:00
JosJuice
0363be4320 WbfsBlob: Remove m_total_files 
std::vector already keeps track of this for us.
 2017-01-11 13:39:38 +01:00
JosJuice
5c02795af0 WbfsBlob: Only open each file once 
The first file used to be opened once by
CreateBlobReader and once inside WbfsFileReader.
 2017-01-11 13:33:27 +01:00
JosJuice
8d54bbc528 Don't create new IOFiles when creating a blob 
...except for WBFS, which is special because
it has the ability to open multiple files.
 2017-01-11 13:23:23 +01:00
JosJuice
d1ea00ed88 Only open file once when detecting blob type 2017-01-11 13:23:19 +01:00
Lioncash
a93861ab49 DiscScrubber: Don't take SFileInfo instances by value 
Avoids unnecessary copies.
 2017-01-04 20:12:49 -05:00
Lioncash
c52d1e735a DiscScrubber: Use an unsigned loop index in ParseDisc 
Prevents an implicit signed to unsigned conversion when assigning a
partition's group number.
 2017-01-04 20:03:12 -05:00
Lioncash
6ff21c48cb DiscScrubber: Correct printf specifiers 2017-01-04 19:56:39 -05:00
Lioncash
b1a2dec78a DiscScrubber: Convert a #define into a typed constant 2017-01-04 19:53:31 -05:00
Lioncash
5b1aae0cbf DiscScrubber: Make struct and variable names conformant to the coding style 2017-01-04 17:04:41 -05:00
Lioncash
4a9bc2340b DiscScrubber: Convert into a class 
Allows potential multiple scrubbers to run at once. Also gets rid of the
need to explicitly clean up resources.
 2017-01-04 16:06:21 -05:00
JosJuice
f85266df20 SConfig: Replace bNTSC with m_region 
This lets us get rid of VideoInterface::SetRegionReg,
a huge hack in CEXIMemoryCard, and some minor things.
 2017-01-02 20:57:48 +01:00
JosJuice
66ea9f5cc1 DiscIO: Add GetRegion function and Region enum 
Instead of needing different switch cases for
converting countries to regions in multiple places,
we now only need a single country-to-region switch case
(in DiscIO/Enums.cpp), and we get a nice Region type.
 2017-01-02 20:57:11 +01:00
JosJuice
8e4a781974 VolumeDirectory: Modernize variable names 2016-12-26 11:45:22 +01:00
JosJuice
00aa2d37e9 VolumeDirectory: Don't use references inappropriately 
Integers should be passed as pointers when a function
modifies them (to make it clear that they get modified).
 2016-12-26 09:52:18 +01:00
Mat M
9c8e27e3bb Merge pull request #4558 from JosJuice/volumedirectory-fst-sort 
VolumeDirectory: Sort the FST
 2016-12-25 17:38:58 -05:00
JosJuice
3196f697bb VolumeDirectory: Use a range-based for loop in ComputeNameSize 2016-12-25 23:01:42 +01:00
JosJuice
f3987d13ea VolumeDirectory: Make m_totalNameSize a local variable 
After BuildFST finishes executing, it's never needed again.
 2016-12-25 22:57:14 +01:00
JosJuice
a502f069e8 VolumeDirectory: Sort the FST 
We can't rely on the OS returning files and directories
in a deterministic order, so we should sort them on our own
if we want VolumeDirectory to work for movies and netplay.
 2016-12-25 22:35:38 +01:00
JosJuice
9bd514ed1c Add TGC disc image compatibility 2016-12-18 18:57:36 +01:00
Léo Lam
31ccfffd38 Common: Add alignment header 
Gets rid of duplicated alignment code.
 2016-12-06 20:33:53 +01:00
David Korth
25fe999a79 Added support for Wii RVT-R disc images. 
These disc images are encrypted and signed using a different set of keys.
We only care about the master key, so we check the signature issuer. If
it matches the debug issuer, then we'll use the RVT-R key. Otherwise,
the previous set of common and Korean keys are used.
 2016-12-01 07:51:29 -05:00
Markus Wick
d5ca153c26 Merge pull request #4401 from JosJuice/rename-getuniqueid 
DiscIO/SConfig: Rename GetUniqueID to GetGameID
 2016-10-31 12:39:27 +01:00
JosJuice
1081497cad DiscIO/SConfig: Rename GetUniqueID to GetGameID 
We call this "game ID" everywhere else, and it's not
actually completely unique.
 2016-10-29 15:24:02 +02:00
JosJuice
d6731d34ef Remove VolumeCreator logs 
These logs are very rarely useful and cause the issue
https://bugs.dolphin-emu.org/issues/9767
 2016-10-29 13:08:24 +02:00
Lioncash
d9eb7c4e80 NANDContentLoader: Add IOFile forward declaration 
This would previously fail to compile when included in files that do not
include FileUtil.h due to lack of a type declaration.

This moves the constructor and destructor into the cpp file in order to
satisfy the requirements of unique_ptr construction and deletion. That is,
unique_ptr requires a concrete type at the point of construction and
destruction. If the constructor or destructor is left in the header, then
at the point of construction or destruction, IOFile will still be
considered an incomplete type, as unique_ptr's deleter will still only be
able to see the forward declaration, which it can't use.
 2016-10-14 20:27:22 -04:00
shuffle2
cc66f0336f Merge pull request #3963 from JosJuice/banner-loaded-failure 
VolumeGC: Set m_banner_loaded when banner loading fails
 2016-10-03 06:33:52 -07:00
Mat M
ccfc081697 Merge pull request #4245 from aldelaro5/logs-levels-changes 
Lots of Logs levels changes (also enable INFO level in every build)
 2016-10-02 16:51:44 -04:00
aldelaro5
f0aa9b3751 Reorganise a ton of logs level 
Most of this commits changes performance decreasing logs from info to debug and also cleans up innacurate levels.
 2016-10-01 15:50:28 -04:00
Lioncash
61b977c914 WiiWad: Make WiiWAD constructor explicit 2016-09-25 18:04:11 -04:00
Lioncash
7de0d51345 WiiWad: Move static implementation details to cpp file 
These functions don't actually depend on any state from the class
instance, so they don't really belong in the header, and are just
an implementation detail.
 2016-09-25 18:04:04 -04:00
Lioncash
144c23dead Filesystem: Return strings from GetFileName without the const qualifier 
This is mostly pointless and can inhibit move construction
 2016-09-18 12:56:25 -04:00
Lioncash
5aeedcd27c NANDContentLoader: Remove unnecessary trailing semicolons 2016-09-14 20:12:25 -04:00
Lioncash
b43a26b90c NANDContentLoader: Remove virtual specifier from CNANDContentLoader destructor 
This class is marked final, so there's no need to declare it as virtual.
 2016-09-14 19:45:52 -04:00
Lioncash
3196bf5392 NANDContentLoader: Specify constructors as explicit where applicable 
Prevents implicit conversion.
 2016-09-14 19:44:44 -04:00
Lioncash
89c65be703 NANDContentLoader: Delay vector construction until needed in Get() 
No need to construct the vector right off the bat.
 2016-09-14 19:41:41 -04:00
Lioncash
b1ffa74043 NANDContentLoader: Make CNANDContentData's Get function return by non-const value 
const specifiers like this are practically pointless and can inhibit move construction.
 2016-09-14 19:15:31 -04:00
EmptyChaos
eccec3c6d3 DiscIO: Fix NAND Memory Leak 
CNANDContentData is a base class with a non-virtual destructor so
derived classes don't get destroyed causing them to leak resources.
 2016-09-14 15:54:05 +10:00
Léo Lam
c1184957a5 Run clang-format on missed files 
`clang-format`s files that lint missed because of the bug. Fortunately,
not much.
 2016-08-11 21:14:39 +02:00
JosJuice
0a15aaaa12 Move DiscIO enums to a new file 
At first there weren't many enums in Volume.h, but the number has been
growing, and I'm planning to add one more for regions. To not make
Volume.h too large, and to avoid needing to include Volume.h in code
that doesn't use volume objects, I'm moving the enums to a new file.
I'm also turning them into enum classes while I'm at it.
 2016-07-13 17:29:27 +02:00
Pierre Bourdon
f4d2626d2b Merge pull request #4005 from EmptyChaos/blockcache-bug 
SectorReader: Minor cache bias bug
 2016-07-13 12:11:19 +02:00
JosJuice
53e7eed28d DiscScrubber: Fix issue 9356 2016-07-11 11:46:15 +02:00
EmptyChaos
9036b9d8e8 SectorReader: Fix cache line bias 
Minor bug where SectorReader::GetEmptyCacheLine was biased towards
the first hit.
 2016-07-09 02:27:35 +10:00
JosJuice
31226b8503 DiscScrubber: Replace unused blocks with 0x00 instead of 0xFF 2016-07-07 11:51:58 +02:00
JosJuice
202c9d58cd VolumeGC: Set m_banner_loaded when banner loading fails 
If banner loading fails once, it will very likely fail again.
Setting m_banner_loaded to true when banner loading fails
prevents LoadBannerFile from wasting time if it's called again.
Banner loading requires loading the file system, which takes a
noticeable amount of time, so this matters.
 2016-06-28 18:05:44 +02:00
JosJuice
1878605d77 Undo some comment formatting changes from b5104a7 2016-06-25 18:07:10 +02:00
Rukai
b5104a79f1 GCVolume: supports reading all opening.bnr information 
DQT2: Game properties dialog contains info tab giving information about the selected iso.
 2016-06-26 00:03:59 +10:00
Pierre Bourdon
3570c7f03a Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Pierre Bourdon
c4240692b6 SectorReader: Fix reading the last block of the disc. 
Regression from PR #3795.
 2016-05-29 18:26:04 +02:00
EmptyChaos
97d570f0c9 DriveReader: Fix View > Show Drives 
DriveReader::m_size was never initialized which was indirectly
causing CGameListCtrl to crash Dolphin when it tried to insert a
character at a negative index in a string.

Reading one sector at a time is very inefficient and appears to
be causing timing issues during boot so SectorReader has been
enhanced to support batching.

SectorReader has been given a working cache system.
 2016-04-26 21:24:08 +10:00
BhaaL
a449ef4e11 properly open/close the file to avoid rapid open/close cycles 
ES_OPENCONTENT and ES_CLOSECONTENT now call Open and Close respectively,
as the old code did.
 2016-03-20 13:10:51 +01:00
BhaaL
8a6d9e1e0b hide the distinction between WAD and File from ES 
instead, leave all the management with the NANDContentLoader.

for file data (directly on the NAND), this opens the file on-demand and
returns the requested chunk when asked for it.
for on-the-fly decrypted WAD data, we just keep the decoded buffer in
memory, like we've done before - except that we don't give away any objects
we don't want to.
 2016-03-20 13:10:50 +01:00
BhaaL
1e28d06f26 fix some style inconsistencies that drove me nuts 2016-03-20 13:10:47 +01:00
booto
92278886b9 DiscIO: Use specified Wii region for discs 2016-01-15 03:35:10 +08:00
Pierre Bourdon
bff79df363 Merge pull request #3429 from sepalani/debug_vector_fix 
Debug Builds: Fixed vector assertion
 2016-01-07 00:48:40 +01:00
JosJuice
81466d7fa3 DolphinWX: Stop using XPM images 
Using the XPM format for images has become a maintenance problem because
people don't know how to create them. This commit removes all XPM images
and all C files that contain PNG images. DolphinWX now uses the PNGs
in the Resources folder instead, just like DolphinQt and DolphinQt2 do.
 2016-01-05 19:11:58 +01:00
Sepalani
ba794272f5 Debug Builds: Fixed vector assertion 2016-01-03 13:17:26 +01:00
Mathew Maidment
1b69743ba1 Merge pull request #3362 from lioncash/memory 
NANDContentLoader/WiiWAD: Get rid of raw delete and new
 2015-12-22 06:39:12 -05:00
Rohit Nirmal
aaa89d4f73 Silence -Wshadow and -Wmaybe-uninitialized warnings. 2015-12-21 10:06:07 -06:00
Lioncash
cbeb7034eb Volume: Make GetTMD return a vector 2015-12-19 18:00:44 -05:00
Lioncash
c78c54c546 NANDContentLoader/WiiWAD: Get rid of raw delete and new 2015-12-19 17:37:09 -05:00
Markus Wick
c310b3f0e6 Merge pull request #3309 from JosJuice/reload-banner-without-volume 
Don't read from volume when reloading Wii banners
 2015-12-15 18:48:49 +01:00
Markus Wick
2990df3f59 Merge pull request #3265 from JosJuice/volumedirectory-simplifications 
DiscIO: Small VolumeDirectory simplifications
 2015-12-15 18:36:49 +01:00
Markus Wick
25a584626f Merge pull request #3127 from JosJuice/read-return 
DiscIO: Improve error handling for reading integers
 2015-12-15 18:16:40 +01:00
Markus Wick
e4b83d17bf Merge pull request #3270 from JosJuice/more-translations 
Mark more strings for translation
 2015-12-15 18:13:26 +01:00
JosJuice
cbfab2a754 DiscIO: Improve DiscScrubber::ReadFromVolume error handling 2015-12-14 10:01:38 +01:00
JosJuice
bd67333da9 DiscIO: Improve CBlobBigEndianReader error handling 2015-12-14 09:56:44 +01:00
JosJuice
c01265db34 DiscIO: Unify CBlobBigEndianReader 2015-12-14 09:38:23 +01:00
JosJuice
c7e747d775 DiscIO: Improve IVolume::Read32 error handling 
Callers can now check whether reads fail, either by checking the return
value or by setting the buffer to a known bad value and seeing if it stays
untouched. I've added error checks to FileSystemGCWii and Boot_BS2Emu,
but not to Boot since it doesn't check any of its other reads either.
 2015-12-14 09:38:21 +01:00