mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-02-21 03:20:04 +02:00

This fixes a problem I was having where using frame advance with the debugger open would frequently cause panic alerts about invalid addresses due to the CPU thread changing MSR.DR while the host thread was trying to access memory. To aid in tracking down all the places where we weren't properly locking the CPU, I've created a new type (in Core.h) that you have to pass as a reference or pointer to functions that require running as the CPU thread.
578 lines
16 KiB
C++
578 lines
16 KiB
C++
// Copyright 2018 Dolphin Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#include "DolphinQt/Debugger/CodeWidget.h"
|
|
|
|
#include <chrono>
|
|
|
|
#include <fmt/format.h>
|
|
|
|
#include <QGridLayout>
|
|
#include <QGroupBox>
|
|
#include <QLabel>
|
|
#include <QLineEdit>
|
|
#include <QListWidget>
|
|
#include <QPushButton>
|
|
#include <QSplitter>
|
|
#include <QTableWidget>
|
|
#include <QWidget>
|
|
|
|
#include "Common/Event.h"
|
|
#include "Core/Core.h"
|
|
#include "Core/Debugger/Debugger_SymbolMap.h"
|
|
#include "Core/HW/CPU.h"
|
|
#include "Core/PowerPC/MMU.h"
|
|
#include "Core/PowerPC/PPCSymbolDB.h"
|
|
#include "Core/PowerPC/PowerPC.h"
|
|
#include "Core/System.h"
|
|
#include "DolphinQt/Host.h"
|
|
#include "DolphinQt/Settings.h"
|
|
|
|
CodeWidget::CodeWidget(QWidget* parent) : QDockWidget(parent)
|
|
{
|
|
setWindowTitle(tr("Code"));
|
|
setObjectName(QStringLiteral("code"));
|
|
|
|
setHidden(!Settings::Instance().IsCodeVisible() || !Settings::Instance().IsDebugModeEnabled());
|
|
|
|
setAllowedAreas(Qt::AllDockWidgetAreas);
|
|
|
|
CreateWidgets();
|
|
|
|
auto& settings = Settings::GetQSettings();
|
|
|
|
restoreGeometry(settings.value(QStringLiteral("codewidget/geometry")).toByteArray());
|
|
// macOS: setHidden() needs to be evaluated before setFloating() for proper window presentation
|
|
// according to Settings
|
|
setFloating(settings.value(QStringLiteral("codewidget/floating")).toBool());
|
|
|
|
connect(&Settings::Instance(), &Settings::CodeVisibilityChanged, this,
|
|
[this](bool visible) { setHidden(!visible); });
|
|
|
|
connect(Host::GetInstance(), &Host::UpdateDisasmDialog, this, [this] {
|
|
if (Core::GetState() == Core::State::Paused)
|
|
SetAddress(PowerPC::ppcState.pc, CodeViewWidget::SetAddressUpdate::WithoutUpdate);
|
|
Update();
|
|
});
|
|
|
|
connect(Host::GetInstance(), &Host::NotifyMapLoaded, this, &CodeWidget::UpdateSymbols);
|
|
|
|
connect(&Settings::Instance(), &Settings::DebugModeToggled, this,
|
|
[this](bool enabled) { setHidden(!enabled || !Settings::Instance().IsCodeVisible()); });
|
|
|
|
connect(&Settings::Instance(), &Settings::EmulationStateChanged, this, &CodeWidget::Update);
|
|
|
|
ConnectWidgets();
|
|
|
|
m_code_splitter->restoreState(
|
|
settings.value(QStringLiteral("codewidget/codesplitter")).toByteArray());
|
|
m_box_splitter->restoreState(
|
|
settings.value(QStringLiteral("codewidget/boxsplitter")).toByteArray());
|
|
}
|
|
|
|
CodeWidget::~CodeWidget()
|
|
{
|
|
auto& settings = Settings::GetQSettings();
|
|
|
|
settings.setValue(QStringLiteral("codewidget/geometry"), saveGeometry());
|
|
settings.setValue(QStringLiteral("codewidget/floating"), isFloating());
|
|
settings.setValue(QStringLiteral("codewidget/codesplitter"), m_code_splitter->saveState());
|
|
settings.setValue(QStringLiteral("codewidget/boxsplitter"), m_box_splitter->saveState());
|
|
}
|
|
|
|
void CodeWidget::closeEvent(QCloseEvent*)
|
|
{
|
|
Settings::Instance().SetCodeVisible(false);
|
|
}
|
|
|
|
void CodeWidget::showEvent(QShowEvent* event)
|
|
{
|
|
Update();
|
|
}
|
|
|
|
void CodeWidget::CreateWidgets()
|
|
{
|
|
auto* layout = new QGridLayout;
|
|
|
|
layout->setContentsMargins(2, 2, 2, 2);
|
|
layout->setSpacing(0);
|
|
|
|
m_search_address = new QLineEdit;
|
|
m_code_diff = new QPushButton(tr("Diff"));
|
|
m_code_view = new CodeViewWidget;
|
|
|
|
m_search_address->setPlaceholderText(tr("Search Address"));
|
|
|
|
m_box_splitter = new QSplitter(Qt::Vertical);
|
|
m_box_splitter->setStyleSheet(QStringLiteral(
|
|
"QSplitter::handle { border-top: 1px dashed black; width: 1px; margin-left: 10px; "
|
|
"margin-right: 10px; }"));
|
|
|
|
auto add_search_line_edit = [this](const QString& name, QListWidget* list_widget) {
|
|
auto* widget = new QWidget;
|
|
auto* line_layout = new QGridLayout;
|
|
auto* label = new QLabel(name);
|
|
auto* search_line_edit = new QLineEdit;
|
|
|
|
widget->setLayout(line_layout);
|
|
line_layout->addWidget(label, 0, 0);
|
|
line_layout->addWidget(search_line_edit, 0, 1);
|
|
line_layout->addWidget(list_widget, 1, 0, -1, -1);
|
|
m_box_splitter->addWidget(widget);
|
|
return search_line_edit;
|
|
};
|
|
|
|
// Callstack
|
|
m_callstack_list = new QListWidget;
|
|
m_search_callstack = add_search_line_edit(tr("Callstack"), m_callstack_list);
|
|
|
|
// Symbols
|
|
m_symbols_list = new QListWidget;
|
|
m_search_symbols = add_search_line_edit(tr("Symbols"), m_symbols_list);
|
|
|
|
// Function calls
|
|
m_function_calls_list = new QListWidget;
|
|
m_search_calls = add_search_line_edit(tr("Calls"), m_function_calls_list);
|
|
|
|
// Function callers
|
|
m_function_callers_list = new QListWidget;
|
|
m_search_callers = add_search_line_edit(tr("Callers"), m_function_callers_list);
|
|
|
|
m_code_splitter = new QSplitter(Qt::Horizontal);
|
|
|
|
m_code_splitter->addWidget(m_box_splitter);
|
|
m_code_splitter->addWidget(m_code_view);
|
|
|
|
layout->addWidget(m_search_address, 0, 0);
|
|
layout->addWidget(m_code_diff, 0, 2);
|
|
layout->addWidget(m_code_splitter, 1, 0, -1, -1);
|
|
|
|
QWidget* widget = new QWidget(this);
|
|
widget->setLayout(layout);
|
|
setWidget(widget);
|
|
}
|
|
|
|
void CodeWidget::ConnectWidgets()
|
|
{
|
|
connect(m_search_address, &QLineEdit::textChanged, this, &CodeWidget::OnSearchAddress);
|
|
connect(m_search_address, &QLineEdit::returnPressed, this, &CodeWidget::OnSearchAddress);
|
|
connect(m_search_symbols, &QLineEdit::textChanged, this, &CodeWidget::OnSearchSymbols);
|
|
connect(m_search_calls, &QLineEdit::textChanged, this, [this]() {
|
|
const Common::Symbol* symbol = g_symbolDB.GetSymbolFromAddr(m_code_view->GetAddress());
|
|
if (symbol)
|
|
UpdateFunctionCalls(symbol);
|
|
});
|
|
connect(m_search_callers, &QLineEdit::textChanged, this, [this]() {
|
|
const Common::Symbol* symbol = g_symbolDB.GetSymbolFromAddr(m_code_view->GetAddress());
|
|
if (symbol)
|
|
UpdateFunctionCallers(symbol);
|
|
});
|
|
connect(m_search_callstack, &QLineEdit::textChanged, this, &CodeWidget::UpdateCallstack);
|
|
|
|
connect(m_code_diff, &QPushButton::pressed, this, &CodeWidget::OnDiff);
|
|
|
|
connect(m_symbols_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectSymbol);
|
|
connect(m_callstack_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectCallstack);
|
|
connect(m_function_calls_list, &QListWidget::itemPressed, this,
|
|
&CodeWidget::OnSelectFunctionCalls);
|
|
connect(m_function_callers_list, &QListWidget::itemPressed, this,
|
|
&CodeWidget::OnSelectFunctionCallers);
|
|
|
|
connect(m_code_view, &CodeViewWidget::SymbolsChanged, this, [this]() {
|
|
UpdateCallstack();
|
|
UpdateSymbols();
|
|
const Common::Symbol* symbol = g_symbolDB.GetSymbolFromAddr(m_code_view->GetAddress());
|
|
if (symbol)
|
|
{
|
|
UpdateFunctionCalls(symbol);
|
|
UpdateFunctionCallers(symbol);
|
|
}
|
|
});
|
|
connect(m_code_view, &CodeViewWidget::BreakpointsChanged, this,
|
|
[this] { emit BreakpointsChanged(); });
|
|
connect(m_code_view, &CodeViewWidget::UpdateCodeWidget, this, &CodeWidget::Update);
|
|
|
|
connect(m_code_view, &CodeViewWidget::RequestPPCComparison, this,
|
|
&CodeWidget::RequestPPCComparison);
|
|
connect(m_code_view, &CodeViewWidget::ShowMemory, this, &CodeWidget::ShowMemory);
|
|
}
|
|
|
|
void CodeWidget::OnDiff()
|
|
{
|
|
if (!m_diff_dialog)
|
|
m_diff_dialog = new CodeDiffDialog(this);
|
|
m_diff_dialog->setWindowFlag(Qt::WindowMinimizeButtonHint);
|
|
m_diff_dialog->show();
|
|
m_diff_dialog->raise();
|
|
m_diff_dialog->activateWindow();
|
|
}
|
|
|
|
void CodeWidget::OnSearchAddress()
|
|
{
|
|
bool good = true;
|
|
u32 address = m_search_address->text().toUInt(&good, 16);
|
|
|
|
QPalette palette;
|
|
QFont font;
|
|
|
|
if (!good && !m_search_address->text().isEmpty())
|
|
{
|
|
font.setBold(true);
|
|
palette.setColor(QPalette::Text, Qt::red);
|
|
}
|
|
|
|
m_search_address->setPalette(palette);
|
|
m_search_address->setFont(font);
|
|
|
|
if (good)
|
|
m_code_view->SetAddress(address, CodeViewWidget::SetAddressUpdate::WithUpdate);
|
|
|
|
Update();
|
|
|
|
m_search_address->setFocus();
|
|
}
|
|
|
|
void CodeWidget::OnSearchSymbols()
|
|
{
|
|
m_symbol_filter = m_search_symbols->text();
|
|
UpdateSymbols();
|
|
}
|
|
|
|
void CodeWidget::OnSelectSymbol()
|
|
{
|
|
const auto items = m_symbols_list->selectedItems();
|
|
if (items.isEmpty())
|
|
return;
|
|
|
|
const u32 address = items[0]->data(Qt::UserRole).toUInt();
|
|
const Common::Symbol* symbol = g_symbolDB.GetSymbolFromAddr(address);
|
|
|
|
m_code_view->SetAddress(address, CodeViewWidget::SetAddressUpdate::WithUpdate);
|
|
UpdateCallstack();
|
|
UpdateFunctionCalls(symbol);
|
|
UpdateFunctionCallers(symbol);
|
|
|
|
m_code_view->setFocus();
|
|
}
|
|
|
|
void CodeWidget::OnSelectCallstack()
|
|
{
|
|
const auto items = m_callstack_list->selectedItems();
|
|
if (items.isEmpty())
|
|
return;
|
|
|
|
m_code_view->SetAddress(items[0]->data(Qt::UserRole).toUInt(),
|
|
CodeViewWidget::SetAddressUpdate::WithUpdate);
|
|
Update();
|
|
}
|
|
|
|
void CodeWidget::OnSelectFunctionCalls()
|
|
{
|
|
const auto items = m_function_calls_list->selectedItems();
|
|
if (items.isEmpty())
|
|
return;
|
|
|
|
m_code_view->SetAddress(items[0]->data(Qt::UserRole).toUInt(),
|
|
CodeViewWidget::SetAddressUpdate::WithUpdate);
|
|
Update();
|
|
}
|
|
|
|
void CodeWidget::OnSelectFunctionCallers()
|
|
{
|
|
const auto items = m_function_callers_list->selectedItems();
|
|
if (items.isEmpty())
|
|
return;
|
|
|
|
m_code_view->SetAddress(items[0]->data(Qt::UserRole).toUInt(),
|
|
CodeViewWidget::SetAddressUpdate::WithUpdate);
|
|
Update();
|
|
}
|
|
|
|
void CodeWidget::SetAddress(u32 address, CodeViewWidget::SetAddressUpdate update)
|
|
{
|
|
m_code_view->SetAddress(address, update);
|
|
|
|
if (update == CodeViewWidget::SetAddressUpdate::WithUpdate ||
|
|
update == CodeViewWidget::SetAddressUpdate::WithDetailedUpdate)
|
|
{
|
|
Settings::Instance().SetCodeVisible(true);
|
|
raise();
|
|
m_code_view->setFocus();
|
|
}
|
|
}
|
|
|
|
void CodeWidget::Update()
|
|
{
|
|
if (!isVisible())
|
|
return;
|
|
|
|
const Common::Symbol* symbol = g_symbolDB.GetSymbolFromAddr(m_code_view->GetAddress());
|
|
|
|
UpdateCallstack();
|
|
|
|
m_code_view->Update();
|
|
m_code_view->setFocus();
|
|
|
|
if (!symbol)
|
|
return;
|
|
|
|
UpdateFunctionCalls(symbol);
|
|
UpdateFunctionCallers(symbol);
|
|
}
|
|
|
|
void CodeWidget::UpdateCallstack()
|
|
{
|
|
if (Core::GetState() == Core::State::Starting)
|
|
return;
|
|
|
|
m_callstack_list->clear();
|
|
|
|
std::vector<Dolphin_Debugger::CallstackEntry> stack;
|
|
|
|
const bool success = [&stack] {
|
|
Core::CPUThreadGuard guard;
|
|
return Dolphin_Debugger::GetCallstack(Core::System::GetInstance(), guard, stack);
|
|
}();
|
|
|
|
if (!success)
|
|
{
|
|
m_callstack_list->addItem(tr("Invalid callstack"));
|
|
return;
|
|
}
|
|
|
|
const QString filter = m_search_callstack->text();
|
|
|
|
for (const auto& frame : stack)
|
|
{
|
|
const QString name = QString::fromStdString(frame.Name.substr(0, frame.Name.length() - 1));
|
|
|
|
if (name.toUpper().indexOf(filter.toUpper()) == -1)
|
|
continue;
|
|
|
|
auto* item = new QListWidgetItem(name);
|
|
item->setData(Qt::UserRole, frame.vAddress);
|
|
m_callstack_list->addItem(item);
|
|
}
|
|
}
|
|
|
|
void CodeWidget::UpdateSymbols()
|
|
{
|
|
const QString selection = m_symbols_list->selectedItems().isEmpty() ?
|
|
QString{} :
|
|
m_symbols_list->selectedItems()[0]->text();
|
|
m_symbols_list->clear();
|
|
|
|
for (const auto& symbol : g_symbolDB.Symbols())
|
|
{
|
|
QString name = QString::fromStdString(symbol.second.name);
|
|
|
|
auto* item = new QListWidgetItem(name);
|
|
if (name == selection)
|
|
item->setSelected(true);
|
|
|
|
// Disable non-function symbols as you can't do anything with them.
|
|
if (symbol.second.type != Common::Symbol::Type::Function)
|
|
item->setFlags(Qt::NoItemFlags);
|
|
|
|
item->setData(Qt::UserRole, symbol.second.address);
|
|
|
|
if (name.toUpper().indexOf(m_symbol_filter.toUpper()) != -1)
|
|
m_symbols_list->addItem(item);
|
|
}
|
|
|
|
m_symbols_list->sortItems();
|
|
}
|
|
|
|
void CodeWidget::UpdateFunctionCalls(const Common::Symbol* symbol)
|
|
{
|
|
m_function_calls_list->clear();
|
|
const QString filter = m_search_calls->text();
|
|
|
|
for (const auto& call : symbol->calls)
|
|
{
|
|
const u32 addr = call.function;
|
|
const Common::Symbol* call_symbol = g_symbolDB.GetSymbolFromAddr(addr);
|
|
|
|
if (call_symbol)
|
|
{
|
|
const QString name =
|
|
QString::fromStdString(fmt::format("> {} ({:08x})", call_symbol->name, addr));
|
|
|
|
if (name.toUpper().indexOf(filter.toUpper()) == -1)
|
|
continue;
|
|
|
|
auto* item = new QListWidgetItem(name);
|
|
item->setData(Qt::UserRole, addr);
|
|
m_function_calls_list->addItem(item);
|
|
}
|
|
}
|
|
}
|
|
|
|
void CodeWidget::UpdateFunctionCallers(const Common::Symbol* symbol)
|
|
{
|
|
m_function_callers_list->clear();
|
|
const QString filter = m_search_callers->text();
|
|
|
|
for (const auto& caller : symbol->callers)
|
|
{
|
|
const u32 addr = caller.call_address;
|
|
const Common::Symbol* caller_symbol = g_symbolDB.GetSymbolFromAddr(addr);
|
|
|
|
if (caller_symbol)
|
|
{
|
|
const QString name =
|
|
QString::fromStdString(fmt::format("< {} ({:08x})", caller_symbol->name, addr));
|
|
|
|
if (name.toUpper().indexOf(filter.toUpper()) == -1)
|
|
continue;
|
|
|
|
auto* item = new QListWidgetItem(name);
|
|
item->setData(Qt::UserRole, addr);
|
|
m_function_callers_list->addItem(item);
|
|
}
|
|
}
|
|
}
|
|
|
|
void CodeWidget::Step()
|
|
{
|
|
if (!CPU::IsStepping())
|
|
return;
|
|
|
|
Common::Event sync_event;
|
|
|
|
PowerPC::CoreMode old_mode = PowerPC::GetMode();
|
|
PowerPC::SetMode(PowerPC::CoreMode::Interpreter);
|
|
PowerPC::breakpoints.ClearAllTemporary();
|
|
CPU::StepOpcode(&sync_event);
|
|
sync_event.WaitFor(std::chrono::milliseconds(20));
|
|
PowerPC::SetMode(old_mode);
|
|
Core::DisplayMessage(tr("Step successful!").toStdString(), 2000);
|
|
// Will get a UpdateDisasmDialog(), don't update the GUI here.
|
|
}
|
|
|
|
void CodeWidget::StepOver()
|
|
{
|
|
if (!CPU::IsStepping())
|
|
return;
|
|
|
|
const UGeckoInstruction inst = [] {
|
|
Core::CPUThreadGuard guard;
|
|
return PowerPC::HostRead_Instruction(guard, PowerPC::ppcState.pc);
|
|
}();
|
|
|
|
if (inst.LK)
|
|
{
|
|
PowerPC::breakpoints.ClearAllTemporary();
|
|
PowerPC::breakpoints.Add(PowerPC::ppcState.pc + 4, true);
|
|
CPU::EnableStepping(false);
|
|
Core::DisplayMessage(tr("Step over in progress...").toStdString(), 2000);
|
|
}
|
|
else
|
|
{
|
|
Step();
|
|
}
|
|
}
|
|
|
|
// Returns true on a rfi, blr or on a bclr that evaluates to true.
|
|
static bool WillInstructionReturn(UGeckoInstruction inst)
|
|
{
|
|
// Is a rfi instruction
|
|
if (inst.hex == 0x4C000064u)
|
|
return true;
|
|
bool counter =
|
|
(inst.BO_2 >> 2 & 1) != 0 || (CTR(PowerPC::ppcState) != 0) != ((inst.BO_2 >> 1 & 1) != 0);
|
|
bool condition =
|
|
inst.BO_2 >> 4 != 0 || PowerPC::ppcState.cr.GetBit(inst.BI_2) == (inst.BO_2 >> 3 & 1);
|
|
bool isBclr = inst.OPCD_7 == 0b010011 && (inst.hex >> 1 & 0b10000) != 0;
|
|
return isBclr && counter && condition && !inst.LK_3;
|
|
}
|
|
|
|
void CodeWidget::StepOut()
|
|
{
|
|
if (!CPU::IsStepping())
|
|
return;
|
|
|
|
// Keep stepping until the next return instruction or timeout after five seconds
|
|
using clock = std::chrono::steady_clock;
|
|
clock::time_point timeout = clock::now() + std::chrono::seconds(5);
|
|
|
|
{
|
|
Core::CPUThreadGuard guard;
|
|
|
|
PowerPC::breakpoints.ClearAllTemporary();
|
|
|
|
PowerPC::CoreMode old_mode = PowerPC::GetMode();
|
|
PowerPC::SetMode(PowerPC::CoreMode::Interpreter);
|
|
|
|
// Loop until either the current instruction is a return instruction with no Link flag
|
|
// or a breakpoint is detected so it can step at the breakpoint. If the PC is currently
|
|
// on a breakpoint, skip it.
|
|
UGeckoInstruction inst = PowerPC::HostRead_Instruction(guard, PowerPC::ppcState.pc);
|
|
do
|
|
{
|
|
if (WillInstructionReturn(inst))
|
|
{
|
|
PowerPC::SingleStep();
|
|
break;
|
|
}
|
|
|
|
if (inst.LK)
|
|
{
|
|
// Step over branches
|
|
u32 next_pc = PowerPC::ppcState.pc + 4;
|
|
do
|
|
{
|
|
PowerPC::SingleStep();
|
|
} while (PowerPC::ppcState.pc != next_pc && clock::now() < timeout &&
|
|
!PowerPC::breakpoints.IsAddressBreakPoint(PowerPC::ppcState.pc));
|
|
}
|
|
else
|
|
{
|
|
PowerPC::SingleStep();
|
|
}
|
|
|
|
inst = PowerPC::HostRead_Instruction(guard, PowerPC::ppcState.pc);
|
|
} while (clock::now() < timeout &&
|
|
!PowerPC::breakpoints.IsAddressBreakPoint(PowerPC::ppcState.pc));
|
|
|
|
PowerPC::SetMode(old_mode);
|
|
}
|
|
|
|
emit Host::GetInstance()->UpdateDisasmDialog();
|
|
|
|
if (PowerPC::breakpoints.IsAddressBreakPoint(PowerPC::ppcState.pc))
|
|
Core::DisplayMessage(tr("Breakpoint encountered! Step out aborted.").toStdString(), 2000);
|
|
else if (clock::now() >= timeout)
|
|
Core::DisplayMessage(tr("Step out timed out!").toStdString(), 2000);
|
|
else
|
|
Core::DisplayMessage(tr("Step out successful!").toStdString(), 2000);
|
|
}
|
|
|
|
void CodeWidget::Skip()
|
|
{
|
|
PowerPC::ppcState.pc += 4;
|
|
ShowPC();
|
|
}
|
|
|
|
void CodeWidget::ShowPC()
|
|
{
|
|
m_code_view->SetAddress(PowerPC::ppcState.pc, CodeViewWidget::SetAddressUpdate::WithUpdate);
|
|
Update();
|
|
}
|
|
|
|
void CodeWidget::SetPC()
|
|
{
|
|
PowerPC::ppcState.pc = m_code_view->GetAddress();
|
|
Update();
|
|
}
|
|
|
|
void CodeWidget::ToggleBreakpoint()
|
|
{
|
|
m_code_view->ToggleBreakpoint();
|
|
}
|
|
|
|
void CodeWidget::AddBreakpoint()
|
|
{
|
|
m_code_view->AddBreakpoint();
|
|
}
|